On Mon, Apr 14, 2008 at 11:46 PM, Stanislav Malyshev <[EMAIL PROTECTED]> wrote:
> Hi all!
>
>
>
> > I wanted to ask the people here for opinions on the subject of functions
> naming in pecl/intl (hopefully soon to be ext/intl ;) module. Current state
> can be seen at http://docs.php.net/manual/en/book.intl.php
> >
>
> Since publishing this mail about 2 weeks ago I have received a number of
> replies, of which I have two stating preferences about the options brought
> up here. Besides that, I also know Derick's opinion from the previous
> discussions. If anybody else has something to contribute to the subject,
> please speak up.
I hope you are keeping in mind our last discussion here. I also like
to know what to think about my API changes proposal and the exception
usages as it is a relatively important request. Or why are you asking?
I really fear to suddenly see a 1.0.0-stable with none of our requests
inside.
Also please find a patch as attachment. It fixes a possible crash in
datefmt_create. I have some more to come but I did not get the time to
finish.
The ICU build problem remains as well. I'm not sure it is safe to use
2k3 binaries with php VC6 binaries. I wonder how you built it using
vc2005. It fails with all possible errors here. Any trick?
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org
Index: dateformat.c
===================================================================
RCS file: /repository/pecl/intl/dateformat/dateformat.c,v
retrieving revision 1.1.2.3
diff -u -r1.1.2.3 dateformat.c
--- dateformat.c 2 Apr 2008 13:28:15 -0000 1.1.2.3
+++ dateformat.c 14 Apr 2008 21:57:24 -0000
@@ -106,8 +106,6 @@
{
intl_error_set( NULL, U_ILLEGAL_ARGUMENT_ERROR,
"datefmt_create: unable to parse input params", 0
TSRMLS_CC );
- zval_dtor(object);
- ZVAL_NULL(object);
RETURN_NULL();
}
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
