On 16.03.2009, at 16:49, Pierre Joye wrote:

2009/3/16 Johannes Schlüter <[email protected]>:
Hi,

On Mon, 2009-03-16 at 09:52 +0000, "Dmitry Stogov" wrote:
Log:
  Fixed bug #47664 (get_class returns NULL instead of FALSE)
[...]
@@ -716,7 +716,7 @@
        int dup;

        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|o",
&obj) == FAILURE) {
-               return;
+               RETURN_FALSE;
        }

Usually we return NULL in case parameter parsing fails, this is
documented like this:

Hi Johannes,

Please read the bug report. In this case I think that we should not
break it only to follow this (arguable :) rule. See the documentation
of get_class as well: http://de.php.net/get_class


I did not follow this closely. So where do we stand here? Should we do a quick vote? Or is this decided already? In this case did it get documented (in case we decided to change the behavior).

If someone can summarize the current state of things I would appreciate it.

regards,
Lukas Kahwe Smith
[email protected]




--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to