On 28.07.2009, at 13:32, Dmitry Stogov wrote:

Hi David,

I took only a quick look, but I like the patch.
In case it doesn't break any tests, it should be committed at least into HEAD. I agree to commit it into 5.3 too, but RMs take the final decision.

The only thing I didn't understood - why win32/php_stdint.h is needed.

Ah, yes, that's probably an oversight. Good catch. The headers were copy-pasted from some ext/date file :)

Another thing that just occured to me is that we now have a dependency on ext/date; I think I had trouble compiling ext/soap as a standalone extension like this. Must check again. Any hints?

- David


Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to