Le mercredi 07 octobre 2009 à 15:47 +0200, Pierre Joye a écrit : > The idea is good and matches my thoughts on this topic. > > Some comments: > - no driver specific API, so getNotices instaed of get<driver>Notices
It was discuss, it need hours to implement this method to all drivers... > - common attribute name as well and maybe a better naming ATTR_LOG_NOTICES? Why not, but it must be in the same time that the last question > 5.2 is also only for security fixes. Can you try to produce a patch > against 5.3 and trunk please? There's the patch of Matteo Beccati at this address for PHP 5.3: http://www.beccati.com/misc/php/pdo_pgsql_notices_php5_3.patch I can make another for the trunk, why not :-). I'll probably try to make this functionality as global today or tomorrow. Thanks for your feedback. Samuel. > Cheers, > > On Wed, Oct 7, 2009 at 3:29 PM, Samuel ROZE <samuel.r...@aliceadsl.fr> wrote: > > Le mercredi 07 octobre 2009 à 07:57 +0200, Samuel ROZE a écrit : > >> Well, i've show the patch this morning... It's great ! The allocation of > >> the HashTable when use setAttribute might not be really a good job but > >> other, in my mind, is ! > >> > >> See you afternoon for PHP 5.2 path. :-) > > > > Well, I've done a patch for PHP 5.2 branch: > > http://www.d-sites.com/wp-content/uploads/2009/10/pdo_pgsql_notices_php5.2.patch > > > > It is working but there are two memory leaks when running with CGI: > > > > [Wed Oct 7 15:20:10 2009] Script: 'pgsql_notice.php' > > /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(105) : Freeing > > 0x01C43A80 (24 bytes), script=pgsql_notice.php > > [Wed Oct 7 15:20:10 2009] Script: 'pgsql_notice.php' > > /usr/src/php-5.2.10/ext/pdo_pgsql/pgsql_driver.c(55) : Freeing > > 0x01C43AF0 (22 bytes), script=pgsql_notice.php > > === Total 2 memory leaks detected === > > > > Joined, the pgsql_driver.c file. > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
