On Fri, Jul 2, 2010 at 8:45 AM, Christopher Jones <[email protected]> wrote: > > > On 07/02/2010 07:11 AM, Stanley Sufficool wrote: >> >> Can I get an affirmation if the pdo dblib code will be accepted in 5.2 >> and 5.3 branches? >> > > It shouldn't go into 5.2 if it introduces new functionality. You > might backport the crash/leak bug fixes if Ilia is OK with that.
Patches for the OOM for 5.2 and 5.3 are attached to BUG #50755 http://bugs.php.net/bug.php?id=50755 There has been feedback on this bug that indicates other are needing this fix as well. This prevents people from developing bigger applications on non-MS Platforms to support SQL Server and Sybase. I would argue that the additional fixes in trunk fix bugs rather than introducing new functionality since they were already in the PDO specification and they do not break BC. I do not see why this would be held out of releases. This passes *most* PDO tests and passes other tests in ext/pdo_dblib/tests. The PDO tests that fail, AFAIK have always failed. FWIW, Microsoft has a monopoly on a fully functional PDO mssql driver which is only implemented on MS platforms. If we want portability of PHP applications, then the PDO DBLIB driver must be fully functional on releases. BTW, This extension is experimental and subject to change. Well it did, and they were warned. Happy Independence Day, Stan > > Depending if how compatible (UI + protocol) it is with 5.3, then > Johannes may accept it into 5.3.4. > > I'm concerned that recent PDO changes (including Ilia's merge of > inTransaction() for Postgres) haven't been documented. Lack of > accurate documentation won't help the consistency of further PDO > driver changes. > > Chris > > -- > Email: [email protected] > Tel: +1 650 506 8630 > Blog: http://blogs.oracle.com/opal/ > Free PHP Book: http://tinyurl.com/ugpomhome > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
