hi Remi!
Thanks for the headup!
Attached patch should fix this problem but I'm not sure if we have to
do it in RINIT instead. The handler is set to NULL on dtor, so it
could be enough already to do it once in MINIT.
Cheers,
On Mon, Dec 26, 2011 at 1:52 PM, Remi Collet <r...@fedoraproject.org> wrote:
> With 321411 applied
>
> (gdb) run -n -m
> Starting program: /dev/shm/php5.4-201112261030/build-zts/sapi/cli/php -n -m
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib64/libthread_db.so.1".
> [PHP Modules]
> bz2
> calendar
> Core
> ... <snip> ...
> zlib
>
> [Zend Modules]
>
>
> Program received signal SIGSEGV, Segmentation fault.
> deflateEnd (strm=0x5e5410) at deflate.c:902
> 902 status = strm->state->status;
> (gdb) bt
> #0 deflateEnd (strm=0x5e5410) at deflate.c:902
> #1 0x0000000000470c31 in php_zlib_cleanup_ob_gzhandler_mess
> (tsrm_ls=0xa360b0) at
> /home/rpmbuild/BUILD/php5.4-201112261030/ext/zlib/zlib.c:434
> #2 0x0000000000470c93 in zm_deactivate_zlib (type=<optimized out>,
> module_number=<optimized out>, tsrm_ls=<optimized out>)
> at /home/rpmbuild/BUILD/php5.4-201112261030/ext/zlib/zlib.c:973
> #3 0x00000000005ee6c0 in zend_deactivate_modules (tsrm_ls=0xa360b0) at
> /home/rpmbuild/BUILD/php5.4-201112261030/Zend/zend_API.c:2325
> #4 0x0000000000577c18 in php_request_shutdown (dummy=<optimized out>)
> at /home/rpmbuild/BUILD/php5.4-201112261030/main/main.c:1756
> #5 0x00000000006a28d5 in do_cli (argc=3, argv=0x7fffffffe048,
> tsrm_ls=0xa360b0) at
> /home/rpmbuild/BUILD/php5.4-201112261030/sapi/cli/php_cli.c:1169
> #6 0x0000000000426467 in main (argc=3, argv=0x7fffffffe048) at
> /home/rpmbuild/BUILD/php5.4-201112261030/sapi/cli/php_cli.c:1356
>
>
> Only a ZTS issue.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
Index: ext/zlib/zlib.c
===================================================================
--- ext/zlib/zlib.c (revision 321411)
+++ ext/zlib/zlib.c (working copy)
@@ -938,7 +938,7 @@
REGISTER_LONG_CONSTANT("ZLIB_ENCODING_GZIP", PHP_ZLIB_ENCODING_GZIP,
CONST_CS|CONST_PERSISTENT);
REGISTER_LONG_CONSTANT("ZLIB_ENCODING_DEFLATE",
PHP_ZLIB_ENCODING_DEFLATE, CONST_CS|CONST_PERSISTENT);
REGISTER_INI_ENTRIES();
-
+ ZLIBG(ob_gzhandler) = NULL;
return SUCCESS;
}
/* }}} */
@@ -969,7 +969,6 @@
static PHP_RSHUTDOWN_FUNCTION(zlib)
{
ZLIBG(output_compression) = 0;
-
php_zlib_cleanup_ob_gzhandler_mess(TSRMLS_C);
return SUCCESS;
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
