On Mon, 27 Feb 2012, Laruence wrote: > On Mon, Feb 27, 2012 at 4:31 PM, Laruence <larue...@php.net> wrote: > > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov <dmi...@zend.com> wrote: > >> > >> The attached patch looks wired. The patch on top of it (r323563) makes it > >> better. However, in my opinion it fixes a common problem just in a single > >> place. Each call to __toString() that makes "side effects" may cause the > >> similar problem. It would be great to make a "right" fix in > >> zend_std_cast_object_tostring() itself, but probably it would require API > > Hi: > > before this fix, I thought about the same idea of that. > > > > but, you know, such change will need all exts who implmented > > their own cast_object handler change there codes too. > > > > for now, I exam the usage of std_cast_object_tostring, most of > > them do the similar things like this fix to avoid this issues(like > > ZEND_CAST handler). > > > > so I think, maybe it's okey for a temporary fix :) > > what I mean temporary is, apply this fix to 5.3 and 5.4 > > then do the "right" fix which you said to 5.4.1 :)
You can't break extension APIs between 5.4.0 and 5.4.1 either, API changes can only into trunk. cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php