On Fri, Sep 27, 2013 at 3:02 PM, Derick Rethans <der...@php.net> wrote:

> On Thu, 26 Sep 2013, Lior Kaplan wrote:
>
> > Hi,
> >
> > In Debian we build PHP for GNU/Hurd system, which need some minor fixes
> > available here:
> >
> >
> http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/116-posixness_fix.patch
>
>   46 --- php5.orig/main/php.h
>   47 +++ php5/main/php.h
>   48 @@ -244,6 +244,10 @@ END_EXTERN_C()
>   49  /* macros */
>   50  #define STR_PRINT(str) ((str)?(str):"")
>   51
>   52 +#ifndef PATH_MAX
>   53 +#define PATH_MAX 4096
>   54 +#endif
>   55 +
>   56  #ifndef MAXPATHLEN
>   57  # ifdef PATH_MAX
>   58  #  define MAXPATHLEN PATH_MAX
>
> That looks wrong. You're unconditionally defining PATH_MAX, but there is
> logic in line 57 that deals with this too...
>

That whole section is about defining MAXPATHLEN, not PATH_MAX.

Kaplan

Reply via email to