On Tue, Aug 26, 2014 at 9:55 PM, Nikita Popov <nikita....@gmail.com> wrote:
> Hi internals! > > Currently our git repo contains files like zend_language_scanner.c, > zend_ini_scanner.c, etc which are files generated by re2c. Historically > these files have been included because re2c was not readily available on > many platforms. In the thread on bison 3 compatibility [1] there was some > discussion as to whether this limitation still applies. Quoting Adam Harvey: > > > +1. I don't think re2c is that onerous a requirement anyway, for the > > most part: it's available through apt-get, brew, yum, and probably > > most other packaging systems. Given the amount of other things a > > developer has to install to build php-src from git, re2c is hardly > > going to break the camel's back. > > So, I'd like to bring this up again. Are there any objections to removing > generated lexer files from the repo? If not, does it suffice to just git rm > them and add them to .gitignore, or are other changes required? > > Nikita > > [1]: http://markmail.org/message/x3p7ltekzws6ywhw > I'd like to bring this up again. It seems the thread got side-tracked with unrelated discussion (about vm_execute.h) and I didn't get any answers to the original question. Case in point: The current zend_language_scanner.c has been generated by Andrea, who uses a different re2c version from everybody else (0.13.6 instead of 0.13.5). This means that if I do some tiny change to zend_language_scanner.l I immediately get a 3000 line diff. So we just end up changing this file back and forth depending on the algorithm used by different versions. Nikita
