Hi, I made some improvements that would like to get merged into PHP, but I require someone with Zend karma to review and merge. The patches are all related and included in each other as a progressive effort. As a quick explanation, the removal of ZEND_ACC_FINAL_CLASS addresses some classes that were not properly assigned as final. They're now final. Examples are COM, PDO Statement, DOM XML and MySQLi. They also reduce the amount of checks of bison when parsing a php file, it provides a nicer fatal error around multiple final and multiple abstract mix between abstract and final instead of a generic parser error. Finally, ZEND_ACC_TRAIT got updated to a saner value. It was pretty complex to comprehend why it was 0x120. It was done because a trait was considered internally as abstract because of instantiation and inheritance checking. This all got addressed too.
Here they are: - ZEND_ACC_TRAIT value update: https://github.com/php/php-src/pull/931 (includes the next one) - Zend language parser class decoupling: https://github.com/php/php-src/pull/928 (includes the next one) - ZEND_ACC_FINAL_CLASS removal: https://github.com/php/php-src/pull/911 Theoretically, merging the first one would mean merging all, but I left them separate for proper case by case evaluation. Regards, -- Guilherme Blanco MSN: guilhermebla...@hotmail.com GTalk: guilhermeblanco Toronto - ON/Canada
