I recently stumbled over that issue, too; thanks for looking into it.

Looking at the patch, it seems, that some handling for bzip2 archives is
missing; I think if there are special cases for .tar, .tgz and .zip,
there should also be a case for .tbz2 (.tar.bz2).

Yep, I discussed this with a friend and did a quick search this morning. It is missing, mostly because I didn't know how popular .tbz2 was as a file extension - it is very rare. In most cases I see .tar.bz2 (a case already handled by .tar). I can add .tbz2 as a handled file extension, and restructure the code accordingly.

Additionally, I've found that phar_detect_phar_fname_ext() also needs some suffix validation, which I will also add.

I will have a new commit for this in place tonight. (Which will also trigger Travis to run again, I think it failed b/c I force pushed my last commit).

Thanks for taking the time, I'll let you know when there are more commits to review.

-ralph

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to