The comment seems to suggest we copied the XtOffset stuff from apache source (which copied it from X), verbatim, is that not explanation enough ?
Is there any particular reason to change it ? Cheers Joe On Fri, Jun 5, 2015 at 2:58 PM, Levi Morrison <le...@php.net> wrote: > On Thu, Jun 4, 2015 at 11:58 PM, Joe Watkins <pthre...@pthreads.org> > wrote: > > Explained here: http://lxr.php.net/xref/PHP_TRUNK/main/php.h#415 > > > > > > On Fri, Jun 5, 2015 at 5:06 AM, Levi Morrison <le...@php.net> wrote: > >> > >> The macro offsetof is required by the C89 standard to be defined in > >> stddef.h and remains in newer standards. The macro XtOffsetOf is > >> non-standard that is as far as I can tell a part of the X Toolkit > >> Intrinsics or Xlib. > >> > >> Does anyone know the reasons why we are using the non-standard macro > >> instead of the standard one? > > Thanks, Joe. However, that code just explains why are macros are that > way. It doesn't justify the use of XtOffsetOf over offsetof, just how > the ifdefs were obtained. >
