Hi Kiklas, On Wed, Sep 21, 2016 at 5:06 PM, Niklas Keller <m...@kelunik.com> wrote: > 2016-09-21 8:54 GMT+02:00 Yasuo Ohgaki <yohg...@ohgaki.net>: >> >> Hi Stas, >> >> On Wed, Sep 21, 2016 at 11:26 AM, Stanislav Malyshev >> <smalys...@gmail.com> wrote: >> > >> >> I think we are better to limit max collisions. >> >> I'm +1 for Nikita's proposal does this. >> > >> > Max collision per what? How much would be the limit? >> >> Collision by keys. >> >> It would be nice to have configurable limit like regex stack/backtrack >> limit. >> That said, wouldn't 1000 enough for almost all apps? > > > Having a limit isn't a good idea for all use cases, but it works for some. > >> >> Anyway, we have two choices >> - Simply limit the number of collisions. (Fast and has no impact to code) > > > It totally has impact to code. What happens if we have enough collisions? > Throw an exception? Might break code, any array insert operation might > suddenly fail. Simply fatal? Not suitable for long running applications like > Aerys (https://github.com/amphp/aerys) or PPM > (https://github.com/php-pm/php-pm). > > I guess to support these use cases, we have to switch to a cryptographic > hash function here. But I guess it would be totally fine having such a > feature as compile flag, limiting the number of collisions usually and > provide a cryptographic hash function for long running apps to protect them. > > I think such an option is fine for those running long running applications, > since they don't rely on setups like shared hosting and can usually compile > their own versions.
It's the same as you're saying that PCRE stack/backtrack limit and/or memory limit is not good idea. The same argument apply to the stack/backtrack/memory limit, but I don't think these limits are bad idea at all. AFIAK, we didn't have a bug report that complains slow hash operation by collisions yet except intended attack, did we? Limit does not have to be 1000, but as many as possible up to the value safe against intended attack. > >> >> - Use crypt safe hash and salt. (Slow and has impact to opcache/etc) > > > Do we need a salt here? If not, how does it then impact opcache? Yes. It's mandatory. Even crypt quality hash has collisions. Attack is possible once attackers collect enough number of collisions. Salt breaks hashed key compatibility. Opcache saves hashes and salt breaks it. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
