> -----Original Message----- > From: p...@golemon.com <p...@golemon.com> On Behalf Of Sara Golemon > Sent: Friday, July 13, 2018 10:27 PM > To: Anatol Belski <a...@php.net> > Cc: Dmitry Stogov <dmi...@zend.com>; Nikita Popov <nikita....@gmail.com>; > PHP internals list <internals@lists.php.net>; Stanislav Malyshev > <smalys...@gmail.com>; der...@derickrethans.nl; Christoph M. Becker > <cmbecke...@gmx.de> > Subject: Re: [PHP-DEV] re2c version(s) > > On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski <a...@php.net> wrote: > >> I ask, because my release builder for 7.2 (and 7.1 if Joe is using > >> Davey's builder) is using re2c 0.13.5 . I don't imagine the risk of > >> updating re2c mid-relase is particularly high, but it is non-zero. > >> > > Normally RMs would define the tool versions that are expected to be > > stable and that are always used for the official tarballs. > > In the case of 7.0, it'd be always re2c 0.13.5 and bison 3.0.2, where > > ever I'd produce the tarball (even I don't always use Jessie for > > packaging). We probably should take this into the release process > > docs, if it isn't there already. > > > Well, whichever version we've settled on, I've updated sgolemon/php-release to > allow using arbitrary versions of re2c. > https://github.com/sgolemon/php- > release/commit/9197257bc6f2f607476f950733a0c13ab5e3e867 > > If RE2C_VERSION is set to 1.0.3, it'll swap in the pre-built 1.0.3 binary I've > included in the package. > Otherwise, it'll clone the source repo, checkout the requested tag (or commit > hash) and build that). > As long as it suffices for the platform targeted for packaging, that'd work. I'd wonder, if we could use this approach to have the exact tools version on Travis. Then it'd be matching with what is tested and released. If that'd be ok, still the Stas concern about other platforms were to be respected. Perhaps we could integrate such a mechanism into the core, but it should fallback to available re2c, bison and whatever, if the given platform can't build the required tool version. As it would be for dev, perhaps it could be ignored, as a release would deliver the generated files. Or, we should still keep the generated files in the repo.
Regards Anatol
