On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > This commit adds device tree support for the TPS6586x regulator. > > Signed-off-by: Thierry Reding <thierry.red...@avionic-design.de>
This looks basically good from a quick scan through but the pattern of looking up regulator nodes by name is very common so should be factored out - I made a similar comment in response to a recent patch from Rhyland Klein and earlier today he posted a patch "regulator: add generic of node parsing for regulators" which does just that. Can you please redo this on top of his code? I'll probably apply it later today, though I didn't properly read the code yet. I guess it should be possible to apply this patch independantly of the rest of the series? It shouldn't break bisection if it's missing as it's a new driver that's being added as the consumer.
signature.asc
Description: Digital signature
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
