> -----Original Message----- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, March 14, 2013 3:20 PM > To: Sethi Varun-B16395 > Cc: j...@8bytes.org; iommu@lists.linux-foundation.org; > linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; b...@kernel.crashing.org; Wood Scott-B07421; Yoder > Stuart-B08248 > Subject: Re: [PATCH 5/5 v9] iommu/fsl: Freescale PAMU driver and iommu > implementation. > > > On Mar 13, 2013, at 1:49 PM, Varun Sethi wrote: > > > +/* > > + * Table of SVRs and the corresponding PORT_ID values. > > + * > > + * All future CoreNet-enabled SOCs will have this erratum fixed, so this > > table > > + * should never need to be updated. SVRs are guaranteed to be unique, so > > + * there is no worry that a future SOC will inadvertently have one of these > > + * values. > > + */ > > Maybe add to the comment about what port_id represents
When you update the comment, I would also suggest identifying the specific errata here (A-004510) so that it's easy to reference back to the specific issue this code is fixing. Stuart _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
