On Thu, Nov 21, 2013 at 11:20 AM, Hiroshi Doyu <hd...@nvidia.com> wrote: > Grant Likely <grant.lik...@linaro.org> wrote @ Thu, 21 Nov 2013 16:56:49 > +0100: > >> On Thu, 21 Nov 2013 15:12:18 +0200, Hiroshi Doyu <hd...@nvidia.com> wrote: >> > On Thu, 21 Nov 2013 13:43:28 +0100 >> > Grant Likely <grant.lik...@linaro.org> wrote: >> > >> > > On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu <hd...@nvidia.com> >> > > wrote: >> > > > The following pattern of code is tempting: >> > > > >> > > > for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); >> > > > i++) >> > > > >> > > > Signed-off-by: Hiroshi Doyu <hd...@nvidia.com> >> > > >> > > That's a very minimal commit message. Can you elaborate please. >> > >> > The above can be: >> > >> > " >> > The following pattern of code is tempting to add a new member for >> > of_property_for_each_*() family as an idiom. >> > >> > for (i = 0; >> > !of_parse_phandle_with_args(np, list, cells, i, args); i++) >> > <do something with "args">; >> > " >> >> I really do like commit messages to be full enough that a future reader >> can figure out why a patch was written. ie: > > Updated as: > > [PATCHv6+ 01/13] of: introduce of_property_for_earch_phandle_with_args()
You also have a typo in the subject. s/earch/each/ Rob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
