On Thursday 05 March 2015 18:56:36 Robin Murphy wrote:
> @@ -1630,6 +1630,13 @@ static int arm_smmu_device_cfg_probe(struct
> arm_smmu_device *smmu)
> size = arm_smmu_id_size_to_bits((id >> ID2_OAS_SHIFT) & ID2_OAS_MASK);
> smmu->pa_size = size;
>
> + /*
> + * What the page table walker can address actually depends on which
> + * descriptor format is in use, but since a) we don't know that yet,
> + * and b) it can vary per context bank, this will have to do...
> + */
> + dma_set_mask_and_coherent(smmu->dev, DMA_BIT_MASK(size));
> +
> if (smmu->version == ARM_SMMU_V1) {
> smmu->va_size = smmu->ipa_size;
> size = SZ_4K | SZ_2M | SZ_1G;
>
dma_set_mask_and_coherent() can fail if the parent bus cannot access all
of RAM. While that would be serious misdesign for an IOMMU, you should not
just ignore that failure and at least print a message once.
Why not just attempt to set a 64-bit mask?
Arnd
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
