On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote: Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
> +- #interrupt-cells: Should be 2, two cells are needed for irq.
> +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain).
> +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x.
I'm not entirely sure what this is but it sounds worrying - why can you
not just use a normal interrupt specifier? It also doesn't correspond
to the example:
> +Example:
> + pmic: pmic@f8000000 {
> + compatible = "hisilicon,hi655x-pmic-driver";
> + reg = <0x0 0xf8000000 0x0 0x1000>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + pmic_gpios = <&gpio_pmu_irq_n>;
> + status = "okay";
> + }
> --
> 1.9.1
>
>
signature.asc
Description: PGP signature
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
