-------- Original Message --------
On 01/27/16 at 07:03pm, Wan Zongshun wrote:
-------- Original Message --------
alias = amd_iommu_alias_table[devid];
table = irq_lookup_table[alias];
@@ -3688,7 +3688,7 @@ static struct irq_remap_table *get_irq_table(u16 devid,
bool ioapic)
/* Nothing there yet, allocate new irq remapping table */
table = kzalloc(sizeof(*table), GFP_ATOMIC);
if (!table)
- goto out;
+ goto out_unlock;
/* Initialize table spin-lock */
spin_lock_init(&table->lock);
@@ -3701,7 +3701,7 @@ static struct irq_remap_table *get_irq_table(u16 devid,
bool ioapic)
if (!table->table) {
kfree(table);
table = NULL;
- goto out;
+ goto out_unlock;
}
memset(table->table, 0, MAX_IRQS_PER_TABLE * sizeof(u32));
So here the 'out:' label text should also remove, since no err need
goto it, right?
out:
iommu_completion_wait(iommu);
Seems we still need out lable here since it need jump to out label if
alias irte table has been set ite irte table of alias will be set in DTE.
It is okay.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
