Hello Joerg Roedel,

This is a semi-automatic email about new static checker warnings.

The patch 9648cbc9625b: "iommu/arm-smmu: Make use of the 
iommu_register interface" from Feb 1, 2017, leads to the following 
Smatch complaint:

drivers/iommu/arm-smmu-v3.c:1810 arm_smmu_remove_device()
         warn: variable dereferenced before check 'master' (see line 1809)

drivers/iommu/arm-smmu-v3.c
  1808          master = fwspec->iommu_priv;
  1809          smmu = master->smmu;
                       ^^^^^^^^^^^^
New dereference.

  1810          if (master && master->ste.valid)
                    ^^^^^^
Old code checked for NULL.

  1811                  arm_smmu_detach_dev(dev);
  1812          iommu_group_remove_device(dev);

regards,
dan carpenter
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to