On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > Move single iommu enabling codes into a wrapper function early_enable_iommu(). > This can make later kdump change easier. > > And also add iommu_disable_command_buffer and iommu_disable_event_buffer > for later usage. > > Signed-off-by: Baoquan He <b...@redhat.com> > --- > drivers/iommu/amd_iommu_init.c | 42 > +++++++++++++++++++++++++++++++----------- > 1 file changed, 31 insertions(+), 11 deletions(-) > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index e39857ce6481..4ca6e3257d92 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -634,6 +634,14 @@ static void iommu_enable_command_buffer(struct amd_iommu > *iommu) > amd_iommu_reset_cmd_buffer(iommu); > } > > +/* > + * This function disables the command buffer > + */ > +static void iommu_disable_command_buffer(struct amd_iommu *iommu) > +{ > + iommu_feature_disable(iommu, CONTROL_CMDBUF_EN); > +} > + > static void __init free_command_buffer(struct amd_iommu *iommu) > { > free_pages((unsigned long)iommu->cmd_buf, get_order(CMD_BUFFER_SIZE)); > @@ -666,6 +674,14 @@ static void iommu_enable_event_buffer(struct amd_iommu > *iommu) > iommu_feature_enable(iommu, CONTROL_EVT_LOG_EN); > } > > +/* > + * This function disables the command buffer
s/command buffer/event log/ > + */ > +static void iommu_disable_event_buffer(struct amd_iommu *iommu) Please also use event_log here. > +{ > + iommu_feature_disable(iommu, CONTROL_EVT_LOG_EN); > +} > + _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu