Hi Jean,
On 2017/10/6 21:31, Jean-Philippe Brucker wrote:
> - if (domain->ext_handler) {
> + if (domain->handler_flags & IOMMU_FAULT_HANDLER_ATOMIC) {
> + fault->flags |= IOMMU_FAULT_ATOMIC;
Why remove the condition of domain->ext_handler? should it be much better like:
if ((domain->handler_flags & IOMMU_FAULT_HANDLER_ATOMIC) &&
domain->ext_handler)
If domain->ext_handler is NULL, and (domain->handler_flags &
IOMMU_FAULT_HANDLER_ATOMIC)
is true. It will oops, right?
> ret = domain->ext_handler(domain, dev, fault,
> domain->handler_token);
Thanks
Yisheng Xie
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
