On 09/03/18 11:44, Jonathan Cameron wrote: > On Mon, 12 Feb 2018 18:33:32 +0000 > Jean-Philippe Brucker <jean-philippe.bruc...@arm.com> wrote: > >> In order to add support for substream ID, move the context descriptor code >> into a separate library. At the moment it only manages context descriptor >> 0, which is used for non-PASID translations. >> >> One important behavior change is the ASID allocator, which is now global >> instead of per-SMMU. If we end up needing per-SMMU ASIDs after all, it >> would be relatively simple to move back to per-device allocator instead >> of a global one. Sharing ASIDs will require an IDR, so implement the >> ASID allocator with an IDA instead of porting the bitmap, to ease the >> transition. >> >> Signed-off-by: Jean-Philippe Brucker <jean-philippe.bruc...@arm.com> > Hi Jean-Philippe, > > This would have been easier to review if split into a 'move' and additional > patches actually making the changes described. > > Superficially it looks like there may be more going on in here than the > above description suggests. I'm unsure why we are gaining > the CFGI_CD_ALL and similar in this patch as there is just to much going on.
Ok I'll try to split this Thanks, Jean _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu