On Thu, 15 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 15, 2018 at 10:00:57AM +0100, Thomas Gleixner wrote: > > On Wed, 14 Mar 2018, Christoph Hellwig wrote: > > > #if defined(CONFIG_INTEL_IOMMU) || defined(CONFIG_AMD_IOMMU) > > > void *iommu; /* hook for IOMMU specific extension */ > > > #endif > > > +#ifdef CONFIG_STA2X11 > > > + bool is_sta2x11 : 1; > > > > Huch? Please use either bool or an unsigned int based bitfield. A boolean > > bitfield doesn't make sense. > > bool bitfields are perfectly valid in C99 and used in various places in > the kernel. But if you want either bool or an unsigned bitfield let me > know and I'll switch it over.
Yeah, I know that the standard defines it, but that doesn't mean it makes sense. At least not to me. Thanks, tglx _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu