On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: > > > +struct dentry *iommu_debugfs_setup(void) > +{ > + if (!debugfs_initialized())
This check is probably not needed. > + return NULL; > + > + if (!iommu_debugfs_dir) > + iommu_debugfs_dir = debugfs_create_dir("iommu", > NULL); > + > + if (iommu_debugfs_dir) > + pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN > ENABLED IN THIS KERNEL\n"); > + As this gets called for each IOMMU, do you want to use pr_warn_once? > + return iommu_debugfs_dir; > +} > +EXPORT_SYMBOL_GPL(iommu_debugfs_setup); -Sohil _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu