On 08/11/2018 14:51, Auger Eric wrote: >>> +/* >>> + * viommu_replay_mappings - re-send MAP requests >>> + * >>> + * When reattaching a domain that was previously detached from all >>> endpoints, >>> + * mappings were deleted from the device. Re-create the mappings available >>> in >>> + * the internal tree. >>> + */ >>> +static int viommu_replay_mappings(struct viommu_domain *vdomain) >>> +{ >>> + int ret; > ret needs to be initialized here. Otherwise this can lead to a crash in > viommu_add_device.
I actually hit this one while testing the other day :) Fixed in next version Thanks, Jean _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu