On 25/04/2019 11:17, Auger Eric wrote: >> +/** >> + * ioasid_alloc - Allocate an IOASID >> + * @set: the IOASID set >> + * @min: the minimum ID (inclusive) >> + * @max: the maximum ID (exclusive) >> + * @private: data private to the caller >> + * >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX). Return the > I would remove "(or %0 and %INT_MAX)".
Agreed, those where the default values of idr, but the xarray doesn't define a default max value. By the way, I do think squashing patches 6 and 7 would be better (keeping my SOB but you can change the author). >> +typedef int (*ioasid_iter_t)(ioasid_t ioasid, void *private, void *data); > I don't see it used in this series. There used to be a "ioasid_for_each()", which isn't needed by anyone at the moment. This can be removed. Thanks, Jean _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
