> On Tue, Jul 02, 2019 at 06:53:59PM -0700, Sai Praneeth Prakhya wrote: > > device_def_domain_type() determines the domain type a device could > > have and it's called only during boot. But, to change the domain of a > > group through sysfs, kernel has to call this function during runtime. > > Hence, add an argument to the function which lets the function know if > > it's being called at boot time or runtime. > > I don't think it should make a difference when the function is actually > called. The > sysfs input is just another variable to take into account when the default > domain > type is determined.
Sure! Makes sense. I will modify the code accordingly. > What I'd like to see for example is that I can write 'auto' to the file and > get back > the systems decision for the default domain type. Sure! Sounds good to me. Will add this functionality. > I'd also like to be able to forbid changing the type for e.g. Thunderbolt > connected devices. This is presently supported in the patch set. But, I got your point, will make sure that untrusted devices are not allowed to change the group. Regards, Sai _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
