MediaTek IOMMU should wait for smi larb which need wait for the
power domain(mtk-scpsys.c) and the multimedia ccf who both are
module init. Thus, subsys_initcall for MediaTek IOMMU is not helpful.
Switch to builtin_platform_driver.

Signed-off-by: Yong Wu <yong...@mediatek.com>
---
 drivers/iommu/mtk_iommu.c    | 31 +------------------------------
 drivers/iommu/mtk_iommu_v1.c | 24 +-----------------------
 2 files changed, 2 insertions(+), 53 deletions(-)

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 2511b3c..109c3f2 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -735,22 +735,6 @@ static int mtk_iommu_probe(struct platform_device *pdev)
        return component_master_add_with_match(dev, &mtk_iommu_com_ops, match);
 }
 
-static int mtk_iommu_remove(struct platform_device *pdev)
-{
-       struct mtk_iommu_data *data = platform_get_drvdata(pdev);
-
-       iommu_device_sysfs_remove(&data->iommu);
-       iommu_device_unregister(&data->iommu);
-
-       if (iommu_present(&platform_bus_type))
-               bus_set_iommu(&platform_bus_type, NULL);
-
-       clk_disable_unprepare(data->bclk);
-       devm_free_irq(&pdev->dev, data->irq, data);
-       component_master_del(&pdev->dev, &mtk_iommu_com_ops);
-       return 0;
-}
-
 static int __maybe_unused mtk_iommu_suspend(struct device *dev)
 {
        struct mtk_iommu_data *data = dev_get_drvdata(dev);
@@ -831,23 +815,10 @@ static int __maybe_unused mtk_iommu_resume(struct device 
*dev)
 
 static struct platform_driver mtk_iommu_driver = {
        .probe  = mtk_iommu_probe,
-       .remove = mtk_iommu_remove,
        .driver = {
                .name = "mtk-iommu",
                .of_match_table = of_match_ptr(mtk_iommu_of_ids),
                .pm = &mtk_iommu_pm_ops,
        }
 };
-
-static int __init mtk_iommu_init(void)
-{
-       int ret;
-
-       ret = platform_driver_register(&mtk_iommu_driver);
-       if (ret != 0)
-               pr_err("Failed to register MTK IOMMU driver\n");
-
-       return ret;
-}
-
-subsys_initcall(mtk_iommu_init)
+builtin_platform_driver(mtk_iommu_driver);
diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index a7f22a2..821d483 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -660,22 +660,6 @@ static int mtk_iommu_probe(struct platform_device *pdev)
        return component_master_add_with_match(dev, &mtk_iommu_com_ops, match);
 }
 
-static int mtk_iommu_remove(struct platform_device *pdev)
-{
-       struct mtk_iommu_data *data = platform_get_drvdata(pdev);
-
-       iommu_device_sysfs_remove(&data->iommu);
-       iommu_device_unregister(&data->iommu);
-
-       if (iommu_present(&platform_bus_type))
-               bus_set_iommu(&platform_bus_type, NULL);
-
-       clk_disable_unprepare(data->bclk);
-       devm_free_irq(&pdev->dev, data->irq, data);
-       component_master_del(&pdev->dev, &mtk_iommu_com_ops);
-       return 0;
-}
-
 static int __maybe_unused mtk_iommu_suspend(struct device *dev)
 {
        struct mtk_iommu_data *data = dev_get_drvdata(dev);
@@ -712,16 +696,10 @@ static int __maybe_unused mtk_iommu_resume(struct device 
*dev)
 
 static struct platform_driver mtk_iommu_driver = {
        .probe  = mtk_iommu_probe,
-       .remove = mtk_iommu_remove,
        .driver = {
                .name = "mtk-iommu-v1",
                .of_match_table = mtk_iommu_of_ids,
                .pm = &mtk_iommu_pm_ops,
        }
 };
-
-static int __init m4u_init(void)
-{
-       return platform_driver_register(&mtk_iommu_driver);
-}
-subsys_initcall(m4u_init);
+builtin_platform_driver(mtk_iommu_driver);
-- 
1.9.1

Reply via email to