On Wed, Sep 04, 2019 at 11:01:18AM +0800, zhong jiang wrote: > Use kzfree instead of memset() + kfree(). > > Signed-off-by: zhong jiang <zhongji...@huawei.com> > --- > drivers/iommu/fsl_pamu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > index cde281b..ca6d147 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -1174,10 +1174,8 @@ static int fsl_pamu_probe(struct platform_device *pdev) > if (irq != NO_IRQ) > free_irq(irq, data); > > - if (data) { > - memset(data, 0, sizeof(struct pamu_isr_data)); > - kfree(data); > - } > + if (data) > + kzfree(data);
kzfree() is doing its own NULL-ptr check, no need to do it here. Regards, Joerg