Hi Robin, On Fri, Oct 25, 2019 at 07:08:29PM +0100, Robin Murphy wrote: > Since the flawed first attempt, I've reworked things with an abstracted > TCR and an explicit TTBR1 quirk. I originally envisaged the need to pass > the quirk all the way down to the TLBI calls, hence getting diverted > into trying to make the parameter passing less cluttered in general, but > in the end it turned out fairly neat to just fix the indexing such that > we can always just pass around the original unmodified IOVA. Most of the > new patches come from staring at that indexing code for long enough to > see the subtle inefficiencies that were worth ironing out, plus a bit of > random cleanup which doesn't feel worth posting separately. > > Note that these patches depend on the fixes already queued in -rc4, > otherwise there will be conflicts in arm_mali_lpae_alloc_pgtable(). > > Robin. > > > Robin Murphy (10): > iommu/io-pgtable: Make selftest gubbins consistently __init > iommu/io-pgtable-arm: Rationalise size check > iommu/io-pgtable-arm: Simplify bounds checks > iommu/io-pgtable-arm: Simplify start level lookup > iommu/io-pgtable-arm: Simplify PGD size handling > iommu/io-pgtable-arm: Simplify level indexing > iommu/io-pgtable-arm: Rationalise MAIR handling > iommu/io-pgtable-arm: Rationalise TTBRn handling > iommu/io-pgtable-arm: Rationalise TCR handling > iommu/io-pgtable-arm: Prepare for TTBR1 usage
Overall, this looks really good to me. There's a bit more work to do (see my comments) and I'd like Jordan to have a look as well, but on the whole it's a big improvement. Thanks. Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
