On Wed, Feb 12, 2020 at 01:59:46PM -0600, Li Yang wrote: > On Wed, Feb 12, 2020 at 4:50 AM Will Deacon <w...@kernel.org> wrote: > > > > On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > > > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > > > introduced a side effect that changed the module name from arm-smmu to > > > arm-smmu-mod. This breaks the users of kernel parameters for the driver > > > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > > > to be consistent. > > > > > > Signed-off-by: Li Yang <leoyang...@nxp.com> > > > --- > > > drivers/iommu/Makefile | 4 ++-- > > > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) > > > > Can't we just override MODULE_PARAM_PREFIX instead of renaming the file? > > I can do that. But on the other hand, the "mod" in the module name > arm-smmu-mod.ko seems to be redundant and looks a little bit weird. > Wouldn't it be cleaner to make it just arm-smmu.ko?
I just didn't fancy renaming the file because it's a pain for backports and why does the name of the module matter? Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu