> Release resources when exiting on error.

I have got doubts that such a change description fits to
the proposed source code adjustment.


…
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct 
> platform_device *pdev)
>       qcom_iommu->dev = dev;
>
>       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -     if (res)
> +     if (res) {
>               qcom_iommu->local_base = devm_ioremap_resource(dev, res);
> +             if (IS_ERR(qcom_iommu->local_base))
> +                     return PTR_ERR(qcom_iommu->local_base);
> +     }
>
>       qcom_iommu->iface_clk = devm_clk_get(dev, "iface");
…

Will the commit message be improved any further?

Would you like to add the tag “Fixes”?

Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to