On Mon 15 Jun 23:13 PDT 2020, John Stultz wrote:
> Tweaks to allow pinctrl-msm code to be loadable as a module.
> This is needed in order to support having the qcom-scm driver,
> which pinctrl-msm calls into, configured as a module.
>
This means that we need a "depends on QCOM_SCM || QCOM_SCM=n" on all
entries in the Kconfig that selects PINCTRL_MSM, or switch PINCTRL_MSM
to be user selectable and make all the others depend on it.
> Cc: Andy Gross <agr...@kernel.org>
> Cc: Bjorn Andersson <bjorn.anders...@linaro.org>
> Cc: Joerg Roedel <j...@8bytes.org>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Jason Cooper <ja...@lakedaemon.net>
> Cc: Marc Zyngier <m...@kernel.org>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Cc: Lina Iyer <il...@codeaurora.org>
> Cc: Saravana Kannan <sarava...@google.com>
> Cc: Todd Kjos <tk...@google.com>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: linux-arm-...@vger.kernel.org
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: John Stultz <john.stu...@linaro.org>
> ---
> drivers/pinctrl/qcom/Kconfig | 2 +-
> drivers/pinctrl/qcom/pinctrl-msm.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index ff1ee159dca2..5a7e1bc621e6 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -2,7 +2,7 @@
> if (ARCH_QCOM || COMPILE_TEST)
>
> config PINCTRL_MSM
> - bool
> + tristate
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c
> b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 83b7d64bc4c1..54a226f682e9 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1355,3 +1355,6 @@ int msm_pinctrl_remove(struct platform_device *pdev)
> }
> EXPORT_SYMBOL(msm_pinctrl_remove);
>
> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. pinctrl-msm driver");
It's the "Qualcomm Technologies, Inc. TLMM driver"
> +MODULE_LICENSE("GPL v2");
> +
Please don't retain my empty line at the end of this file :)
Regards,
Bjorn
> --
> 2.17.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
