On Sat, Aug 29, 2020 at 07:58:46AM +0100, Christoph Hellwig wrote: > On Fri, Aug 28, 2020 at 07:05:02PM +0300, Andy Shevchenko wrote: > > Compiler is not happy about hidden declaration of intel_iommu_ops. > > > > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' > > was not declared. Should it be static? > > > > Move declaration to header file to make compiler happy. > > What about a factoring out a helper that does iommu_device_sysfs_add + > iommu_device_set_ops + iommu_device_register and then mark > intel_iommu_ops static?
I am okay with this proposal, but I think the better if IOMMU folks can answer to this before I'm going to invest time into it. -- With Best Regards, Andy Shevchenko _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
