On 2021-03-16 2:00 a.m., Christoph Hellwig wrote: > On Thu, Mar 11, 2021 at 04:31:39PM -0700, Logan Gunthorpe wrote: >> Create a specific error code for when P2PDMA pages are passed to a block >> devices that cannot map them (due to no IOMMU support or ACS protections). >> >> This makes request errors in these cases more informative of as to what >> caused the error. > > I really don't think we should bother with a specific error code here, > we don't add a new status for every single possible logic error in the > caller. I originally had BLK_STS_IOERR but those errors suggested to people that the hardware had failed on the request when in fact it was a user error. I'll try BLK_STS_TARGET unless there's any objection or someone thinks another error code would make more sense. Logan _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
- Re: [RFC PATCH v2 07/11] dma-mapping: Add flags to ... Christoph Hellwig
- [RFC PATCH v2 05/11] lib/scatterlist: Add flag for indic... Logan Gunthorpe
- [RFC PATCH v2 10/11] nvme-pci: Check DMA ops when indica... Logan Gunthorpe
- [RFC PATCH v2 08/11] iommu/dma: Support PCI P2PDMA pages... Logan Gunthorpe
- Re: [RFC PATCH v2 08/11] iommu/dma: Support PCI P2P... Robin Murphy
- Re: [RFC PATCH v2 08/11] iommu/dma: Support PCI... Logan Gunthorpe
- Re: [RFC PATCH v2 08/11] iommu/dma: Support... Robin Murphy
- Re: [RFC PATCH v2 08/11] iommu/dma: Sup... Logan Gunthorpe
- [RFC PATCH v2 09/11] block: Add BLK_STS_P2PDMA Logan Gunthorpe
- Re: [RFC PATCH v2 09/11] block: Add BLK_STS_P2PDMA Christoph Hellwig
- Re: [RFC PATCH v2 09/11] block: Add BLK_STS_P2P... Logan Gunthorpe
- [RFC PATCH v2 06/11] dma-direct: Support PCI P2PDMA page... Logan Gunthorpe
- Re: [RFC PATCH v2 06/11] dma-direct: Support PCI P2... Robin Murphy
- Re: [RFC PATCH v2 06/11] dma-direct: Support PC... Logan Gunthorpe
- Re: [RFC PATCH v2 06/11] dma-direct: Suppor... Robin Murphy
- Re: [RFC PATCH v2 06/11] dma-direct: Su... Logan Gunthorpe
- Re: [RFC PATCH v2 06/11] dma-direc... Christoph Hellwig
- Re: [RFC PATCH v2 06/11] dma-d... Logan Gunthorpe
- Re: [RFC PATCH v2 06/11] dma-direct: Su... Christoph Hellwig
- Re: [RFC PATCH v2 06/11] dma-direct: Support PCI P2... Christoph Hellwig
- [RFC PATCH v2 01/11] PCI/P2PDMA: Pass gfp_mask flags to ... Logan Gunthorpe