Apologies for my mistake: devid = get_device_id(dev) is need, only the check is unnecessary.
Thanks, Shaokun On 2021/4/9 9:31, Shaokun Zhang wrote: > 'devid' has been checked in function check_device, no need to double > check and clean up this. > > Cc: Joerg Roedel <j...@8bytes.org> > Cc: Will Deacon <w...@kernel.org> > Signed-off-by: Shaokun Zhang <zhangshao...@hisilicon.com> > --- > drivers/iommu/amd/iommu.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c > index b4fa94a97446..4130df7c30c6 100644 > --- a/drivers/iommu/amd/iommu.c > +++ b/drivers/iommu/amd/iommu.c > @@ -1676,10 +1676,6 @@ static struct iommu_device > *amd_iommu_probe_device(struct device *dev) > if (!check_device(dev)) > return ERR_PTR(-ENODEV); > > - devid = get_device_id(dev); > - if (devid < 0) > - return ERR_PTR(devid); > - > iommu = amd_iommu_rlookup_table[devid]; > > if (dev_iommu_priv_get(dev)) > @@ -1967,10 +1963,6 @@ static void amd_iommu_detach_device(struct > iommu_domain *dom, > if (!check_device(dev)) > return; > > - devid = get_device_id(dev); > - if (devid < 0) > - return; > - > if (dev_data->domain != NULL) > detach_device(dev); > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
