On Wed, Aug 11, 2021 at 10:02:48PM +0800, Lu Baolu wrote: > On 2021/8/11 21:49, Andy Shevchenko wrote: > > On Fri, Jul 30, 2021 at 09:01:41PM +0800, Lu Baolu wrote: > > > On 2021/7/30 16:05, Andy Shevchenko wrote: > > > > On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: > > > > > On 7/30/21 12:35 AM, Andy Shevchenko wrote: > > > > > > Compiler is not happy about hidden declaration of intel_iommu_ops. > > > > > > > > > > > > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol > > > > > > 'intel_iommu_ops' was not declared. Should it be static? > > > > > > > > > > > > Move declaration to header file to make compiler happy. > > > > > > > > > > Thanks for the cleanup. Sharing data structures between different > > > > > files > > > > > doesn't seem to be a good design. How about adding a helper so that > > > > > the > > > > > intel_iommu_ops could be a static one? > > > > > > > > Whatever suits the purpose. > > > > Can you apply patch 2 of this series, please? > > > > > > Yes, I will. Thanks! > > > > Gentle reminder. > > Thanks. Normally I will queue the vt-d patches to Joerg in the rc6 week.
I see, but don't we need to have them in Linux Next for a few weeks for testing? Perhaps you need to add your tree to be integrated in the Linux Next? -- With Best Regards, Andy Shevchenko _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
