On Mon, Aug 02, 2021 at 09:20:30PM +1000, Michael Ellerman wrote: > Will Deacon <w...@kernel.org> writes: > > Commit ad6c00283163 ("swiotlb: Free tbl memory in swiotlb_exit()") > > introduced a set_memory_encrypted() call to swiotlb_exit() so that the > > buffer pages are returned to an encrypted state prior to being freed. > > > > Sachin reports that this leads to the following crash on a Power server: > > > > [ 0.010799] software IO TLB: tearing down default memory pool > > [ 0.010805] ------------[ cut here ]------------ > > [ 0.010808] kernel BUG at arch/powerpc/kernel/interrupt.c:98! > > > > Nick spotted that this is because set_memory_encrypted() is issuing an > > ultracall which doesn't exist for the processor, and should therefore > > be gated by mem_encrypt_active() to mirror the x86 implementation. > > > > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > Cc: Claire Chang <tien...@chromium.org> > > Cc: Christoph Hellwig <h...@lst.de> > > Cc: Robin Murphy <robin.mur...@arm.com> > > Fixes: ad6c00283163 ("swiotlb: Free tbl memory in swiotlb_exit()") > > Suggested-by: Nicholas Piggin <npig...@gmail.com> > > Reported-by: Sachin Sant <sach...@linux.vnet.ibm.com> > > Tested-by: Sachin Sant <sach...@linux.vnet.ibm.com> > > Tested-by: Nathan Chancellor <nat...@kernel.org> > > Link: > > https://lore.kernel.org/r/1905cd70-7656-42ae-99e2-a31fc3812...@linux.vnet.ibm.com/ > > Signed-off-by: Will Deacon <w...@kernel.org> > > --- > > arch/powerpc/platforms/pseries/svm.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Thanks. > > Acked-by: Michael Ellerman <m...@ellerman.id.au> > > > I assume Konrad will take this via the swiotlb tree?
Btw, we're currently reworking that whole "am I running as a confidential guest" querying, see: https://lkml.kernel.org/r/029791b24c6412f9427cfe6ec598156c64395964.1627424774.git.thomas.lenda...@amd.com for example. I see Konrad has queued this for 5.15 in his devel/for-linus-5.15 branch so if he sends it to Linus in the upcoming merge window (right Konrad?) then I can base the rework ontop, once 5.15-rc1 releases, so that there are no build breakages... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu