Joerg,
On 4/28/2022 3:24 PM, Joerg Roedel wrote:
> Hi Vasant,
>
> On Mon, Apr 25, 2022 at 05:03:40PM +0530, Vasant Hegde wrote:
>> +/*
>> + * This structure contains information about one PCI segment in the system.
>> + */
>> +struct amd_iommu_pci_seg {
>> + struct list_head list;
>
> The purpose of this list_head needs a comment.
Sure.
>
>> +
>> + /* PCI segment number */
>> + u16 id;
>> +};
>> +/*
>> + * List with all PCI segments in the system. This list is not locked because
>> + * it is only written at driver initialization time
>> + */
>> +extern struct list_head amd_iommu_pci_seg_list;
>
> So there will never be hotplug of a PCI segment? Say together with
> hotplugging a CPU?
As I understood currently we don't support hotplugging.
>
>> +static void __init free_pci_segment(void)
>
> This needs plural: free_pci_segments(), as it frees all segments.
>
Sure. Will fix it in v3.
-Vasant
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
