On 2022/7/7 09:01, Tian, Kevin wrote:
From: Lu Baolu <baolu...@linux.intel.com>
Sent: Saturday, July 2, 2022 9:56 AM

-out_unlock:
+       set_bit(num, iommu->domain_ids);
+       info->refcnt = 1;
+       info->did    = num;
+       info->iommu  = iommu;
+       domain->nid  = iommu->node;

One nit. this line should be removed as it's incorrect to blindly update
domain->nid and we should just leave to domain_update_iommu_cap()
to decide the right node. Otherwise this causes a policy conflict as
here it is the last attached device deciding the node which is different
from domain_update_iommu_cap() which picks the node of the first
attached device.

Agreed and updated. Thank you!


Otherwise,

Reviewed-by: Kevin Tian <kevin.t...@intel.com>

Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to