On Wed, Mar 12, 2003 at 12:31:58AM +0200, Tuomo Valkonen wrote:
On Tue, Mar 11, 2003 at 11:15:49PM +0100, Andreas Happe wrote:
Attached is a new version of my toggle_tabs patch...

It might be finally time to apply the patch now that I don't have to worry about it when generalizing the frame code :).

well, I've found out that my font problems were not related to my patch at all... I enabled:

# GNU/Linux and other glibc-2.2 based systems.
DEFINES += -DCF_UTF8 -DCF_ICONV_TARGET=\"WCHAR_T\" -DCF_ICONV_SOURCE=\"UTF-8\"

the program compiles without problems, it starts without problems... but
it doesn't display any fonts... some error message would be nice

you can test the patch anytime, only think is, that you must run patch
with the -R switch as I reversed the directory order when diff'ing...

I think the best way to
implement the toggle_tab feature would be to modify the xxxframe_yyy_geom
functions to use 0 for bar_h when the tab is disabled.

I've just done that in ionframe_managed_geom, the other geom functions are not needed, because the *draw_frame_* functions return before there's anything to draw.

The flag is stored with the whole genframe.flag... on read out it is
matched versus a filter to remove unwanted flags. I've used
genframe.flag because it seemed as the logical place for the flag.

Andreas

Reply via email to