On Friday 21 August 2015 23:55:59 Carsten Bormann wrote:
> Thiago Macieira wrote:
> > On Friday 21 August 2015 20:31:05 Carsten Bormann wrote:
> >>> Tinycbor isn't being updated automatically since it's an external
> >>> library.
> >>> 
> >>>     To update tinycbor, run 'git pull' in 'extlibs/tinycbor/tinycbor'.
> >> 
> >> The top-level makefile should automate just that (giving the actual
> >> commit that is desired, of course, so you can do a controlled update).
> > 
> > We'd rather not cause more network traffic during the build.
> > 
> > The Yocto recipes, for example, are supposed to build code without network
> > access.
> 
> 1) Not wanting to do something on every build is not a reason to not
> automate that something.

Correct, but the automation may be incorrect. We can't simply pull, as 
tinycbor my have advanced incompatibly without the necessary changes landing 
in IoTivity.

A Git submodule link is probably the right thing to do. When people do their 
git pulls, it will update the submodule too.

> 2) No network traffic at all is needed to check whether the correct
> version of a repository has been checked out.  The build must not
> proceed if that isn't the case.  (It is then a matter of style whether
> the situation is automatically rectified or the fix is left to a manual
> recovery and restart.)

This is what it does now.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

Reply via email to