> -----Original Message----- > From: iotivity-dev-bounces at lists.iotivity.org [mailto:iotivity-dev- > bounces at lists.iotivity.org] On Behalf Of Keane, Erich > Sent: Tuesday, January 27, 2015 9:49 > To: Macieira, Thiago > Cc: iotivity-dev at lists.iotivity.org > Subject: Re: [dev] Control Manager > > I come down with Thiago here. From a contributor's perspective, generated > code is bad enough. However, if I have patch that I'm preparing to submit a > pull request/code review for, and the project re-generates existing code, > you've just made my patch likely unmergeable or even impossible to submit. > > The fact that projects DO sometimes re-generate code always makes me > incredibly tentative to even try to modify generated code (even if they > DON'T regenerate). I've only submitted a very small amount to open source > projects and have been burned in the past, so I guess its a 'once bitten > twice shy' kinda thing. > > If this project made it a habit of ever regenerating code, it would > definitely scare off developers. I agree with Erich here.
We need to make sure the code always keep high quality and good shape to attract developers. I do not think the generator code always can be good enough to be merged. Even it is merged, it will cost us big efforts to maintain it. Maintainable and readable is very important to us.
