Hi,

Now also to the mailing list.

You applied my patch https://gerrit.iotivity.org/gerrit/#/c/1802/  which makes 
the build process fail if shared libs are having any unresolved symbols. These 
unresolved symbols are an error in IoTivity. I found some places where 
dependencies to other shared libs were missing and fixed them in the patches 
before that patch, so I made a pull request which contained more than one 
patch. When Jenkins tested them he tested the patch and all the patches it 
depends on this, so it was tested successfully because I fixed all the places 
where shared libs with unresolved symbols  were built in patches before the 
patches added the warnings.
Now this patch which make the build process check for these unresolved symbols 
was cherry-picked and not all the other patches before were applied. This now 
broke the build of upstream IoTivity.

To fix the immediate problem you should apply these patches:
https://gerrit.iotivity.org/gerrit/1795
https://gerrit.iotivity.org/gerrit/1796
https://gerrit.iotivity.org/gerrit/1799
https://gerrit.iotivity.org/gerrit/1800
https://gerrit.iotivity.org/gerrit/1825

I think we should not make big patches (Gerrit marks the size already red) and 
them we will get pull requests with more than one patch which cannot be applied 
in an arbitrary order.
When applying patches you should take more care about their dependencies, 
Gerrit shows a list of related changes which are the other patches which are in 
this patchset.

Hauke Mehrtens
Lantiq Beteiligungs-GmbH & Co.KG

office:      Lilienthalstra?e 15, 85579 Neubiberg Germany
phone:    +49 (89) 89899 - 7179
e-mail:     hauke.mehrtens at lantiq.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150724/d3210b11/attachment.html>

Reply via email to