On Mon, Jun 15, 2015 at 3:47 PM, Jon A. Cruz <jonc at osg.samsung.com> wrote: > > > On 06/15/2015 01:08 PM, Rees, Kevron wrote: >> Attached is the full patch. It's a nasty nasty hack but it may >> illustrate just what a person has to do to build without gtest, >> hippomocks and to check if cereal is already installed on the OS >> before trying to download it. >> >> I'd love to discuss what the "right way" to achieve the same >> objectives. The catalyst for this patch was that iotivity doesn't >> build with yocto when behind a proxy because the proxy environment is >> cleared during compile time. The solution for yocto is to create >> recipes for the dependencies that iotivity tries to download. >> However, iotivity does not even look for the dependencies outside of >> extlibs. So it will ignore that those deps are already available on >> the OS and try to download another copy. >> >> Further, I don't think having unit tests built is useful for users so >> I made it so they can only be built if TEST==1. But even if someone >> does think they are necessary, scons should check the OS to see if all >> the dependencies are already installed before trying to download (or >> perhaps, stop trying to download at all). >> > > OK. I think I see the immediate problem. > > Yes, building without a connection would be good. That is definitely an > aspect that bothers me. I've had issues with this on other projects > where eventually things needed to get fixed to not hit the Internet on a > build. > > *However* we have one bit that stands out. > > You've brought up downloading gtest explicitly as a problem. Actually, > that is an issue to itself. The designed intent with gtest is that it > really should be included in the project's source tree. This is separate > from the issue where the build should check to see if it has something > before trying to download it. > > So if the source/build were changed to use gtest the way its developers > intended then that would be one less issue for you to be hitting. >
Yes, I think that would solve that issue. Is the same true for hippomocks? > > > -- > Jon A. Cruz - Senior Open Source Developer > Samsung Open Source Group > jonc at osg.samsung.com
