I think the intent of this one was that you'd just use registerResource directly, so there is no longer a need to call registerResourceWithHost (it just always uses it!).
So you should be able to change the code in the group to just use register resource, and it shoudl work the same. This would be better, since it is a single function that handles everyone the same, thus would be less likely to be broken. On Thu, 2015-06-25 at 09:35 +0000, ??? wrote: > Hi. Erich, > > > > There is still a problem for OCCreateResourceWithHost absence in your > commit, https://gerrit.iotivity.org/gerrit/#/c/1247/ > > I'm trying to compile the code, but it fails. > > > > Please resolve this issue. > > > > Best Regards, > > Jihun Ha. > > > > ------- Original Message ------- > > Sender : Keane, Erich<erich.keane at intel.com> > > Date : 2015-06-13 01:33 (GMT+09:00) > > Title : Re: [dev] Sudden Function removal for Group Management. > > > > It seems that Charlie pushed this one: > https://gerrit.iotivity.org/gerrit/#/c/1247/ > right before I pushed mine. I'd prefer Charlie's fix since it is > smaller (1247), so please ensure that this meets your requirements if > at > all possible. > > Thanks! > -Erich > > On Fri, 2015-06-12 at 16:30 +0000, Keane, Erich wrote: > > Ah, thanks for the clarification! > > > > I've put a revert review here: > > https://gerrit.iotivity.org/gerrit/#/c/1258/ > > > > Please pull and validate this if you can, I'd like to ensure that > this > > doesn't break anything by just reverting it, and that it'll still > fix > > your issue. > > > > Thanks, > > Erich > > > > On Thu, 2015-06-11 at 23:42 +0000, ??? wrote: > > > Hi. Keane, > > > > > > > > > > > > I'm Jihun Ha who is one of developers for Things Manager service. > > > > > > > > > > > > Please refer to con-client application which is one of Things > > > Manager's sample application. > > > > > > After discovering desired resources from the network, it tries to > > > register the found resource so as to bind these with a group > resource. > > > The found resource is a remote resource thus we have to use > > > registerResource having 2 parameters: > > > > > > OCStackResult > OCPlatform_impl::registerResource(OCResourceHandle& > > > resourceHandle, > > > const std::shared_ptr< > > > OCResource > resource) > > > > > > Inside this function, registerResourceWithHost() function was > called. > > > > > > > > > > > > The case which Things Manager takes care of is the situation where > > > multiple resources with same URI are discovered and we create a > group > > > resource with these found reosurces which are members. Think about > > > group scenario with same resource type, e.g., all bulbs group. > > > > > > > > > > > > Best Regards > > > > > > > > > > > > ------- Original Message ------- > > > > > > Sender : Keane, Erich > > > > > > Date : 2015-06-12 05:07 (GMT+09:00) > > > > > > Title : Re: [dev] Sudden Function removal for Group Management. > > > > > > > > > > > > Then I don't get what was using this function? I thought Uze said > > > ThingsManager was, but if it didn't use this call, what is the > issue? > > > > > > > > > On Thu, 2015-06-11 at 18:39 +0000, Lenahan, Charlie wrote: > > > > ThingsManager is being built by jenkins > > > > > > > > Compiling > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ActionSet.o > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/GroupManager.o > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/GroupSynchronizatio > > > > n.o > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ThingsConfiguration > > > > .o > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ThingsDiagnostics.o > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ThingsManager.o > > > > Compiling > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ActionSet.os > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/GroupManager.os > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/GroupSynchronizatio > > > > n.os > > > > Archiving > > > > > out/linux/x86_64/release/service/things-manager/libTGMSDKLibrary.a > > > > Indexing Archive > > > > > out/linux/x86_64/release/service/things-manager/libTGMSDKLibrary.a > > > > Install file: > > > > > "out/linux/x86_64/release/service/things-manager/libTGMSDKLibrary.a" > > > as > > > > "out/linux/x86_64/release/libTGMSDKLibrary.a" > > > > Compiling > > > > > > > > out/linux/x86_64/release/service/things-manager/sdk/src/ThingsConfiguration > > > > .os > > > > > > > > > > > > > > > > It uses the C++ API which the patchset didn?t change. > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 6/11/15, 1:29 PM, "Keane, Erich" wrote: > > > > > > > > >The patch didn't break the build at all, is Things Manager not > > > building > > > > >as a part of our build system? It seemed like a partially > > > implemented > > > > >function that didn't really accomplish anything, and that no > one > > > was > > > > >using (as far as we could tell at the time). > > > > > > > > > >I'd be OK with reverting the patch if it is still in use > (though > > > it'll > > > > >take a rebase), though I'm concerned that it took this long for > it > > > to > > > > >come to light... > > > > > > > > > >Additionally, from looking at the code, it seems that the > purpose > > > is to > > > > >just have a context to a resource object, which can be dealt > with > > > via > > > > >std::bind on the EntityHandler. > > > > > > > > > >On Fri, 2015-06-12 at 02:25 +0900, ???(Uze Choi) wrote: > > > > >> Things Manager uses it. > > > > >> > > > > >> Function Internally host parameter is processed. > > > > >> > > > > >> > > > > >> > > > > >> BR, Uze Choi > > > > >> > > > > >> From: Lenahan, Charlie [mailto:charlie.lenahan at intel.com] > > > > >> Sent: Friday, June 12, 2015 1:23 AM > > > > >> To: ???(Uze Choi); Keane, Erich > > > > >> Cc: iotivity-dev at lists.iotivity.org > > > > >> Subject: Re: [dev] Sudden Function removal for Group > Management. > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> How was it referenced. The internal structure that had it > wasn?t > > > > >> exposed anywhere. > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> There is a change > https://gerrit.iotivity.org/gerrit/#/c/1042/ > > > that > > > > >> adds a callback parameter to CreateResource. > > > > >> > > > > >> > > > > >> Would that be a better fit? > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> Charlie Lenahan | Software Engineer | Intel Corporation | > 322 > > > West > > > > >> Main Street | Louisville, KY 40202 | W - 502.963.0917 | > > > 8-963.0917 > > > > >> charlie.lenahan at intel.com | CDG ? WINS ? WSS EAST > > > > >> | http://www.linkedin.com/in/charlielenahan > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> From: "??? (Uze Choi)" > > > > >> Date: Thursday, June 11, 2015 at 3:48 AM > > > > >> To: "Keane, Erich" > > > > >> Cc: "iotivity-dev at lists.iotivity.org" > > > > >> > > > > >> Subject: [dev] Sudden Function removal for Group Management. > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> Charlie/Morrow/Erich > > > > >> > > > > >> > > > > >> > > > > >> From the https://gerrit.iotivity.org/gerrit/#/c/1143 change, > > > > >> CreateResourceWithHost() function has been removed. > > > > >> > > > > >> Commit comment says, ?host member is never referenced > anywhere? > > > but, > > > > >> it is definitely referenced from the Primitive service. > > > > >> > > > > >> Furthermore, this is the essential function for the Group > > > Management > > > > >> feature which is officially published release feature. > > > > >> > > > > >> > > > > >> > > > > >> Due to the removal of it, Group related function does not > work > > > > >> anymore. > > > > >> > > > > >> I was upset when this was removed and submitted even Morrow > > > commented > > > > >> that this function had been implemented from Samsung folk. > > > > >> > > > > >> > > > > >> > > > > >> I wish you guide us what should we do enable it again. > > > > >> > > > > >> > > > > >> > > > > >> BR, Uze Choi > > > > >> > > > > >> > > > > > > > > > > > _______________________________________________ > > > iotivity-dev mailing list > > > iotivity-dev at lists.iotivity.org > > > https://lists.iotivity.org/mailman/listinfo/iotivity-dev > > > > > > > > > > > > > > > > > > > > > ?????. ??? ??. > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Jihun Ha (???/???, Ph.D.) > > > > > > IoT, IoTivity, OIC | IoT Solution Lab > > > > > > Software R&D Center | Samsung Electronics Co., Ltd > > > > > > Mobile +82 10 2533 7947 > > > > > > jihun.ha at samsung.com | jhha85 at gmail.com > > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > iotivity-dev mailing list > > iotivity-dev at lists.iotivity.org > > https://lists.iotivity.org/mailman/listinfo/iotivity-dev > > > > > > > > ?????. ??? ??. > > > > Best Regards, > > > > Jihun Ha (???/???, Ph.D.) > > IoT, IoTivity, OIC | IoT Solution Lab > > Software R&D Center | Samsung Electronics Co., Ltd > > Mobile +82 10 2533 7947 > > jihun.ha at samsung.com | jhha85 at gmail.com > > > > > > >
