Uh, and don?t forget OS X and iOS.
From: ASHOKBABU CHANNA <ashok.channa at samsung.com<mailto:[email protected]>> Reply-To: "ashok.channa at samsung.com<mailto:ashok.channa at samsung.com>" <ashok.channa at samsung.com<mailto:ashok.channa at samsung.com>> Date: Tuesday, May 5, 2015 at 11:07 PM To: "Light, John J" <john.j.light at intel.com<mailto:john.j.light at intel.com>>, "iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>" <iotivity-dev at lists.iotivity.org<mailto:iotivity-dev at lists.iotivity.org>> Subject: Re: [dev] patch to eliminate all "singlethread" source files in IoTivity Dear John, Connectivity abstraction supports 4 platforms ? Android, Tizen, Ubuntu and Arduino, with multiple adapters (BT, BLE). Your changes need to be compiled and tested ( basic features) on supported platforms before merging it to master. And your new changes are already in the progress with following gerrits 1)https://gerrit.iotivity.org/gerrit/#/c/783/8 - single thread file removal (pushed on Apr20th) 2)https://gerrit.iotivity.org/gerrit/#/c/752/ - single ip adapter for WIFI and Ethernet(pushed on Apr15th) We are handling changes incrementally as multiple platforms are involved. Your commit, make conflicts with 5 other patch sets and all contributors need to rebase the code and test it again for BT and BLE. (If you did not test your changes , it will creates more effort) To avoid these kind of problem, working groups are requesting proposals first before starting implementations. If you want to contribute, please make a proposal first or at least create a discussion in developers group(like glib discussion) Pat, Could you guide how we are going to handle this situation? Some developers may want to contribute in one platform but it will create issues in other platforms and features. I think handling with proposals first at least make sure people aware of the situation. Regards, Ashok ------- Original Message ------- Sender : Light, John J<john.j.light at intel.com<mailto:john.j.light at intel.com>> Date : May 02, 2015 05:05 (GMT+09:00) Title : [dev] patch to eliminate all "singlethread" source files in IoTivity I pushed to Gerrit a patch 876 which eliminates all ?_singlethread? files, responding to JIRA IOT-509. These files represent a significant fraction of technical debt IoTivity has accrued. My interest in doing this is my concern about applying IPv6 to them. I decided it would be easier to eliminate them than to deal with them. I started this on Monday. IOT-509 provides the technical approach used. Here are some stats. ? 43 files affected. ? 27 files with substantial changes. ? 17 ?_singlethread? files deleted. ? 6122 lines changed. ? 381 lines support the new single thread paradigm. ? 450 lines are mods to Ethernet and Wifi linux ?server? code to allow testing and debugging on Ubuntu. ? 5390 lines are from the 17 deleted files. Of course, this required no changes to API or any other externally visible part of IoTivity. I?m sure the performance is no worse than the previous single thread solution. (I suspect the performance is indistinguishable from multithread performance.) I made no changes to multi-threaded operation. The only problem at this point is that Jenkins reports that it fails to build on Arduino because of an include file problem, which I suspect someone with an Arduino environment could find a fix in five minutes. No change was made to Arduino code. If we push this to master quickly, it will save lots of work for everybody. While Gerrit shows conflicts with five other patch sets, I suspect the collisions are tiny and can be resolved easily. John Light Intel OTC OIC Development [cid:Z5JE7EUABGFC at namo.co.kr] -------------- next part -------------- A non-text attachment was scrubbed... Name: 201505061207446_BEI0XT4N.gif Type: image/gif Size: 13168 bytes Desc: 201505061207446_BEI0XT4N.gif URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20150506/16b6c12f/attachment.gif>
