I had to make progress, so I changed them. We can talk about backing them out.
I'm close to doing the first push.
John
-----Original Message-----
From: Keane, Erich
Sent: Friday, May 08, 2015 12:56 PM
To: Light, John J
Cc: iotivity-dev at lists.iotivity.org
Subject: Re: [dev] build broken (for loops)
Unfortunately no, without a good look at what is going on with your code, I'm a
little in the dark. I DEFINITELY don't want the loops changed, however if you
don't have any ideas, I'd suggest pushing to a review and pinging me again
monday, and I can look at it if other tasks get done.
On Fri, 2015-05-08 at 19:40 +0000, Light, John J wrote:
> I did the same grep in root and got exactly the same lines.
>
> Any more thoughts?
>
> John
>
> -----Original Message-----
> From: Keane, Erich
> Sent: Friday, May 08, 2015 11:22 AM
> To: Light, John J
> Cc: iotivity-dev at lists.iotivity.org
> Subject: Re: [dev] build broken (for loops)
>
> [ekeane1 at ekeane1-desk1 iotivity]$ git checkout master Switched to branch
> 'master'
> Your branch is up-to-date with 'origin/master'.
> [ekeane1 at ekeane1-desk1 iotivity]$ git grep -n "\-std=c99"
> build_common/android/SConscript:48:env.AppendUnique(CFLAGS =
> ['-std=c99'])
> build_common/arduino/SConscript:347: comm_flags = ['-std=c99']
> build_common/arduino/SConscript:385:
> comm_flag.extend(['-std=c99', '-DARDUINO_ARCH_AVR'])
> build_common/iotivityconfig/compiler/gcc_configuration.py:50: #
> e.g. '-std=c99'.
> build_common/iotivityconfig/compiler/gcc_configuration.py:51:
> return [ '-std=c99',
> extlibs/tinydtls/Makefile.in:54:CFLAGS:=-Wall -pedantic -std=c99 @CFLAGS@
> extlibs/tinydtls/aes/Makefile.in:41:CFLAGS=-Wall -std=c99 -pedantic @CFLAGS@
> extlibs/tinydtls/ecc/Makefile.in:50:CFLAGS=-Wall -std=c99 @CFLAGS@
> -DTEST_INCLUDE extlibs/tinydtls/sha2/Makefile.in:41:CFLAGS=-Wall -std=c99
> -pedantic @CFLAGS@
> resource/csdk/SConscript:59: liboctbstack_env.AppendUnique(CFLAGS =
> ['-std=c99'])
> resource/csdk/connectivity/build/android/SConscript:48:env.AppendUniqu
> e(CFLAGS = ['-std=c99'])
> resource/csdk/connectivity/build/android/jni/Android.mk:143:LOCAL_CFLA
> GS
> += -std=c99
> resource/csdk/connectivity/build/arduino/SConscript:347:
> comm_flags = ['-std=c99']
> resource/csdk/connectivity/build/arduino/SConscript:385:
> comm_flag.extend(['-std=c99', '-DARDUINO_ARCH_AVR'])
> resource/csdk/connectivity/build/tizen/scons/SConscript:14:
> env.AppendUnique(CFLAGS = ['-std=c99', '-fPIC',
> '-D__TIZEN__','-DWITH_POSIX',
> '-Wall','-D_GNU_SOURCE','-DTIZEN_DEBUG_ENABLE'])
> resource/csdk/connectivity/build/tizen/scons/SConscript:16:
> env.AppendUnique(CFLAGS = ['-std=c99', '-fPIC',
> '-D__TIZEN__','-DWITH_POSIX', '-Wall', '-DSLP_SDK_LOG',
> '-g','-D_GNU_SOURCE','-DTIZEN_DEBUG_ENABLE'])
> resource/csdk/connectivity/lib/libcoap-4.1.1/Makefile.in:29:CFLAGS:=-W
> all -Wextra -std=c99 -pedantic @CFLAGS@
> resource/csdk/connectivity/samples/tizen/scons/SConscript:16:env.Appen
> dUnique(CFLAGS = ['-std=c99', '-fPIC', '-D__TIZEN__','-DWITH_POSIX',
> '-Wall', '-DSLP_SDK_LOG', '-g','-D_GNU_SOURCE','-DTIZEN_DEBUG_ENABLE',
> '-DTB_LOG','`pkg-config', '--cflags', '--libs','dlog', 'com.oic.ca',
> 'capi-network-wifi',
> resource/oc_logger/SConscript:42:
> liboc_logger_env.AppendUnique(CFLAGS = ['-Wall', '-std=c99', '-fPIC'])
> resource/oc_logger/examples/SConscript:44:
> examples_env.AppendUnique(CFLAGS = Split('-Wall -std=c99 -Werror'))
> [ekeane1 at ekeane1-desk1 iotivity]$
>
>
>
> On Fri, 2015-05-08 at 18:19 +0000, Light, John J wrote:
> > I did a very straightforward rebase, and things magically disappear that I
> > haven't touch anything near.
> >
> > I believe git made a mistake. (And because I reported this, the
> > Android guys I work with are describing similar behavior.)
> >
> > Can you point me to where the -std=c99 flags are supposed to be set? I
> > would rather you do that than let me fix it and tell me I did it wrong.
> >
> > John
> >
> > -----Original Message-----
> > From: Keane, Erich
> > Sent: Friday, May 08, 2015 11:08 AM
> > To: Light, John J
> > Cc: iotivity-dev at lists.iotivity.org
> > Subject: Re: [dev] build broken (for loops)
> >
> > It seems in attempts to rebase you may have lost a few -std=c99 flags.
> >
> > On Fri, 2015-05-08 at 18:03 +0000, Light, John J wrote:
> > > When I compile, I get
> > >
> > >
> > >
> > > 'for' loop initial declarations are only allowed in C99 mode
> > >
> > >
> > >
> > > all over the place. I haven?t done anything I know of to change
> > > the build options.
> > >
> > >
> > >
> > > Clearly, the code used to build, and now it doesn?t. I thought
> > > the modern C style (and compiler) disallowed initial declarations
> > > because of the confusion about scope.
> > >
> > >
> > >
> > > What are we supposed to do here? I?m changing the code to pass
> > > since I have no clue about how the compiler options are supposed to be
> > > set.
> > >
> > >
> > >
> > > Please advise.
> > >
> > >
> > >
> > > John
> > >
> > >
> > > _______________________________________________
> > > iotivity-dev mailing list
> > > iotivity-dev at lists.iotivity.org
> > > https://lists.iotivity.org/mailman/listinfo/iotivity-dev
> >
>
